Module:Navbox - Revision history

Sushoff: 1 revision imported

2025-11-18T15:03:23Z

1 revision imported

← Older revision	Revision as of 15:03, 18 November 2025
(No difference)

en>Ahecht: Remove redundant arghash calculation

2025-09-04T01:16:44Z

Remove redundant arghash calculation

← Older revision		Revision as of 01:16, 4 September 2025
Line 579:		Line 579:
	)		)
	else		else
	nav:attr('aria-label', cfg.aria_label)		nav:attr('aria-label', cfg.aria_label .. args.argHash)
	end		end
	elseif border == cfg.keyword.border_subgroup then		elseif border == cfg.keyword.border_subgroup then
Line 854:		Line 854:
	-- Read the arguments in the order they'll be output in, to make references		-- Read the arguments in the order they'll be output in, to make references
	-- number in the right order.		-- number in the right order.
	local _ ~~= 0~~		local _
	_ = ~~_ + (~~args[prefix .. cfg.arg.title] ~~and #args[prefix .. cfg.arg.title] or 0)~~		_ = args[prefix .. cfg.arg.title]
	_ = ~~_ + (args[prefix .. cfg.arg.above] and #~~args[prefix .. cfg.arg.above] ~~or 0)~~		_ = args[prefix .. cfg.arg.above]
	-- Limit this to 20 as covering 'most' cases (that's a SWAG) and because		-- Limit this to 20 as covering 'most' cases (that's a SWAG) and because
	-- iterator approach won't work here		-- iterator approach won't work here
	for i = 1, 20 do		for i = 1, 20 do
	_ = ~~_ + (args[prefix .. andnum('group', i)] and #~~args[prefix .. andnum('group', i)] ~~or 0)~~		_ = args[prefix .. andnum('group', i)]
	if inArray(cfg.keyword.subgroups, args[prefix .. andnum('list', i)]) then		if inArray(cfg.keyword.subgroups, args[prefix .. andnum('list', i)]) then
	for _, v in ipairs(cfg.arg.subgroups_and_num) do		for _, v in ipairs(cfg.arg.subgroups_and_num) do
Line 868:		Line 868:
	end		end
	end		end
	_ = ~~_ + (~~args[prefix .. cfg.arg.below] ~~and #args[prefix .. cfg.arg.below] or 0)~~		_ = args[prefix .. cfg.arg.below]
	~~return _~~
	end		end

Line 876:		Line 875:
	end		end
	local args = getArgs(frame, {wrappers = {cfg.pattern[boxtype or 'navbox']}})		local args = getArgs(frame, {wrappers = {cfg.pattern[boxtype or 'navbox']}})
	~~args.argHash =~~ readArgs(args, "")		readArgs(args, "")
			args.argHash = nil -- we shouldn't accept argHash passed from a template
	args.type = args.type or cfg.keyword[boxtype]		args.type = args.type or cfg.keyword[boxtype]
	return p['_navbox'](args)		return p['_navbox'](args)

imported>Ahecht: cfg.pattern.without_first_col → cfg.category.without_first_col

2025-01-23T22:26:03Z

cfg.pattern.without_first_col → cfg.category.without_first_col

← Older revision		Revision as of 22:26, 23 January 2025
Line 835:		Line 835:
	and isblank(pargs[andnum('colfooter', 1)]) then		and isblank(pargs[andnum('colfooter', 1)]) then
	targs[andnum('list', 1)] = targs[andnum('list', 1)] ..		targs[andnum('list', 1)] = targs[andnum('list', 1)] ..
	~~'[[' ..~~ cfg.~~pattern~~.without_first_col ~~.. ']]'~~		cfg.category.without_first_col
	end		end

imported>Ahecht: Error checking for weird arg names that might fool cfg.pattern.listnum (such as "list01")

2025-01-23T21:41:33Z

Error checking for weird arg names that might fool cfg.pattern.listnum (such as "list01")

← Older revision		Revision as of 21:41, 23 January 2025
Line 546:		Line 546:
	if type(k) == 'string' then		if type(k) == 'string' then
	local listnum = k:match(cfg.pattern.listnum)		local listnum = k:match(cfg.pattern.listnum)
	if listnum then table.insert(listnums, tonumber(listnum)) end		if listnum and args[andnum('list', tonumber(listnum))] then
			table.insert(listnums, tonumber(listnum))
			end
	end		end
	end		end

imported>Ahecht: Third time's the charm?

2025-01-22T20:38:00Z

Third time's the charm?

Show changes

imported>Bkell: Restored revision 1271145375 by User:Queen of Hearts (talk): Lua error in Module:Navbox at line 535: attempt to get length of local 'arg' (a number value).

2025-01-22T20:13:05Z

Restored revision 1271145375 by User:Queen of Hearts (talk): Lua error in Module:Navbox at line 535: attempt to get length of local 'arg' (a number value).

Show changes

imported>Ahecht: Remove /sandbox

2025-01-22T20:06:55Z

Remove /sandbox

← Older revision		Revision as of 20:06, 22 January 2025
Line 1:		Line 1:
	require('strict')		require('strict')
	local p = {}		local p = {}
	local cfg = mw.loadData('Module:Navbox/configuration~~/sandbox~~')		local cfg = mw.loadData('Module:Navbox/configuration')
	local inArray = require("Module:TableTools").inArray		local inArray = require("Module:TableTools").inArray
	local getArgs -- lazily initialized		local getArgs -- lazily initialized
Line 156:		Line 156:
	local function renderNavBar(titleCell)		local function renderNavBar(titleCell)
	if has_navbar() then		if has_navbar() then
	local navbar = require('Module:Navbar~~/sandbox~~')._navbar		local navbar = require('Module:Navbar')._navbar
	titleCell:wikitext(navbar{		titleCell:wikitext(navbar{
	[cfg.navbar.name] = args[cfg.arg.name],		[cfg.navbar.name] = args[cfg.arg.name],

imported>Ahecht: Second try to consolidate Module:Navbox, Module:Navbox with columns, and Module:Navbox with collapsible groups per Template talk:Navbox#Revisiting merging Module:Navbox, Module:Navbox with collapsible groups, and Module:Navbox with columns. Feel free to revert if this causes problems.

2025-01-22T20:04:24Z

Second try to consolidate Module:Navbox, Module:Navbox with columns, and Module:Navbox with collapsible groups per Template talk:Navbox. Feel free to revert if this causes problems.

Show changes

imported>Queen of Hearts: Restored revision 1243116216 by Ahecht (talk): Lua error in Module:Navbox at line 192: attempt to concatenate field 'argHash' (a nil value).

2025-01-22T19:39:50Z

Restored revision 1243116216 by Ahecht (talk): Lua error in Module:Navbox at line 192: attempt to concatenate field 'argHash' (a nil value).

Show changes

imported>Ahecht: Don't point to sandbox

2025-01-22T19:34:00Z

Don't point to sandbox

← Older revision		Revision as of 19:34, 22 January 2025
Line 1:		Line 1:
	require('strict')		require('strict')
	local p = {}		local p = {}
	local cfg = mw.loadData('Module:Navbox/configuration~~/sandbox~~')		local cfg = mw.loadData('Module:Navbox/configuration')
	local inArray = require("Module:TableTools").inArray		local inArray = require("Module:TableTools").inArray
	local getArgs -- lazily initialized		local getArgs -- lazily initialized
Line 156:		Line 156:
	local function renderNavBar(titleCell)		local function renderNavBar(titleCell)
	if has_navbar() then		if has_navbar() then
	local navbar = require('Module:Navbar~~/sandbox~~')._navbar		local navbar = require('Module:Navbar')._navbar
	titleCell:wikitext(navbar{		titleCell:wikitext(navbar{
	[cfg.navbar.name] = args[cfg.arg.name],		[cfg.navbar.name] = args[cfg.arg.name],